Release v0.24.0 (please TEST!) #8890
Comments
|
Not a regression, but the long press hint for the "Show future videos" button in the subscription feed doesn't change to indicate whether the left-pointing or right-pointing icon is show/don't show. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
|
Finally. This release fixed my fullscreen issue #8774. Thanks . If this will be the final release then I should be able to use regular newpipe builds again instead of debug builds. |
|
Somebody reported on reddit that still sometimes the wrong notification thumbnail is shown when switching videos. After some testing it seems like this is reproducible only on Android 13 (and maybe 12). Here are the full reproduction steps:
=> The second video will start playing, but the shown thumbnail will be that of the first video. The strange thing is that the color of the thumbnail actually adapts to the thumbnail of the second video, which implies the OS must receive the correct thumbnail somewhere, since it's up to the OS to decide the notification color. I could also confirm that the correct thumbnail is set in the media session by using https://github.com/googlesamples/android-media-controller/. I will investigate a little more and give updates here. |
|
Android 12 (CalyxOS): The thumbnail gets updated correctly. |
@eladkarako On playback, on download, on all formats? Could you explain your issue a bit, please? Also it seems you blocked all the TeamNewPipe organization members since a while. |
Is this the same issue as #8906? |
|
Tapping on either Screenrecorder-2022-08-29-20-20-12-230.mp4 |
|
@SameenAhnaf I think that bug is present also in 0.23.3, so it's not a regression, though I agree it looks strange |
|
The |
Close, but not quite. The WebM video format appears to experience the throttling issue during playback, and even then only with certain channels and videos. Not sure if the MP4 format playback can replicate it so easily. Sometimes power cycling home networking equipment solves the issue, but not for long and not with every video example.
Using mobile data can handle the affected video format more easily, somehow. Background playback of a WebM video proceeds as normal with minimal issue, but foreground playback and rendering of the WebM video is where the problem occurs. |
|
Small update on my prior comment. Removing the 2 secondary RF antennae on my NETGEAR XR500 router (it comes with 4) appears to have solved the issue for Youtube-encoded WebM video playback. The strange thing is why this worked, when other apps seemed to maintain typical connectivity with all 4 antennae connected. Maybe they were interfering with each other? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Thumbnails in the feed tab are incorrectly resized, this only happens in the feed tab.
Opening a video updates the thumbnail correctly:
Thumbnails in channel and trending tabs are resized correctly:
Using a OnePlus Nord 2, with Android 12 |
Strange. They show fine on Android 12 Calyx. |
|
Yeah i've been trying out a few things and it seems like the problem only appears after importing both database and configs from my 0.23.1 instance of newpipe |
|
I can confirm, using fast feed. This is not a problem in the UI, but rather in the extractor, since it seems to provide thumbnails with black bars at the top and at the bottom. It should be solvable easily, I think. |
|
No more RCs for this one? |
|
Steps to reproduce an app crash
Exception
Crash log
|
This comment was marked as spam.
This comment was marked as spam.
|
@Locorock could you test the apk provided in TeamNewPipe/NewPipeExtractor#927? It should fix the thumbnail issue in the feed |
|
@SameenAhnaf regarding #8890 (comment), I tried to implement it but unfortunately it is not a good solution. The button in the top bar is actually a checkbox, so showing "hide future videos" when the button is checked and showing "show future videos" when the button is unchecked is confusing and non-standard behavior. So I think we will not change this, and at least not during the release process. |
|
Can't the hint be changed independently of the item text? |
Comment, crash log and screenshot for thumbnails not loading
Exception
Honestly no idea about what is going on, but this showed upon opening a video with the wrong thumbnail 
And now this
|
|
@Locorock thank you for testing. Let's try with another method. I updated the APK in TeamNewPipe/NewPipeExtractor#927, please check if this one works ;-) @ktprograms you are right, I'm stupid 😂, I opened #8966 which should add tooltips. |
Screenshot, crash log and heap dump of (unrelated) |
|
Uhm, that's a different issue and has nothing to do with thumbnails. Try to import an old database (i.e. where the feed has not been updated in a while), reload the feed and see if the new videos's thumbnails load correctly (the thumbnails of videos that were already in the feed before reloading won't change). |
|
Yeah, seems to be working fine for the new videos |
|
Thank you again for testing. Now that the issue is solved I compressed some of your comments into single comments so that they are not "in mezzo" ;-) |
|
The following PRs were merged, so I updated the release candidate APKs. Please do one last test, then we can release :-)
|
|
The Show/Hide future items long-press tooltip still doesn't change. |
|
|
|
Even when I go out and back in, or even close (and kill from the switcher) the app, it doesn't change. |
|
Wooops you are right ;-) |
I guess it's about network speed, more antennae faster speed. |
|
Managed to get all 4 Wi-Fi antennas working again with minimal issue now.
something weird was going on at the time.
A different, though potentially related networking overhead source was
found in a specific setting within the app.
Under Settings, Appearance, Player Notification, having the *Colorize
Notification* setting turned On, even on a supported device such as a
Samsung Galaxy S9, is apparently a very intensive or janky app function, to
the point where the app destabilizes with it on.
Turning it Off seemed to reduce the chance of a failure to parse and load
Like counts, may have improved video playback consistency, and a DNS
benchmarking tool reported generally lower latencies across the board with
the function disabled. It is strange, but it could not be replicated with
disabling the player notification's thumbnail preview showing as well,
seemingly isolating it to that function being a source of general app
instability.
Odd.
…On Thu, Sep 22, 2022, 1:50 AM xz-dev ***@***.***> wrote:
Small update on my prior comment. Removing the 2 secondary RF antennae on
my NETGEAR XR500 router (it comes with 4) appears to have solved the issue
for Youtube-encoded WebM video playback.
The strange thing is why this worked, when other apps seemed to maintain
typical connectivity with all 4 antennae connected. Maybe they were
interfering with each other?
I guess it's about network speed, more antennae faster speed.
—
Reply to this email directly, view it on GitHub
<#8890 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH6CZIUCVVA7P6QROSB4JOLV7PXUFANCNFSM57ZLKLJQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Crashes when too many downloads are going at once. (More than 10.) |
|
@anoraktrend No crash on 0.23.3 with so many downloads? |
That probably depends on your phone specs. Who downloads 10 videos at a time? |
|
Newpipe by default enable limit download queue, if it happens with it enabled that is something to be investigated. If not that just the hardware being pushed to limit |
Testing for regressions
Debug APK (built by our CI in #8889): NewPipe_v0.24.0_RC3_debug.zip
Release APK (built and signed by @Stypox): NewPipe_v0.24.0_RC3_release.zip
Please report only regressions (i.e. new issues) here, not issues that were already present in previous releases!
TODO
Show future videosicon behavior Release v0.24.0 (please TEST!) #8890 (comment) Show correct tooltips for actions in feed #8966NewPipeExtractor version
This version of NewPipe will ship with NewPipe Extractor commit TeamNewPipe/NewPipeExtractor@5c710da.
-> we are going to change the exposed extractor API again soon, so no official release will be done until then ;-)
App changelog
New
minSdkto 21 (Android 5 Lollipop) and drop support for Android 4.4 KitKat Bump minSdk to 21 - Android 5 / Lollipop #7613Improved
scaleTypefitCenterMake thumbnails'scaleTypefitCenter#8573Fixed
Localization
Development
ViewCompat.setBackgroundTintList()Use ViewCompat.setBackgroundTintList(). #8633List.of(),Set.of(),Map.of()Use Java 9 collection factories. #8631 Fix ListHelperTest failure caused by immutable list being used #8679MathUtils.clamp()Use range-limiting methods. #8651 Replace coerceIn() with MathUtils.clamp(). #8737FocusAwareCoordinatorRemove deprecated method calls in FocusAwareCoordinator. #8670Throwable.stackTraceToString()Use Throwable.stackTraceToString(). #8701setBottomSheetCallback()Remove uses of setBottomSheetCallback(). #8669LicenseFragmentHelperRefactor LicenseFragmentHelper. #8682OnClickGesturean interface Make OnClickGesture an interface. #8721View.ktsize Reduce View.kt size. #8708toArray()with zero-length arrays Use toArray() with zero-length arrays. #8724Comparatorfactory methods Use Comparator factory methods. #8728Collectors.joining()Use Collectors.joining(). #8738The text was updated successfully, but these errors were encountered: