Update dependencies

[CreepySkeleton]

syn, proc_macro2 and quote were updated recently. Since you're going to publish a breaking version anyway we could ship this update along. Anyway, we will have to do it sooner or later and now it's a perfect opportunity.

[TeXitoi]

Any idea why the span of Option<Option<T>> is different on nightly? (that's why travis is not happy)

[TeXitoi]

Your git config seems also unsync with your git account.

[CreepySkeleton]

Your git config seems also unsync with your git account.

Oops, thanks for pointing out :)

Any idea why the span of Option<Option<T>> is different on nightly? (that's why travis is not happy)

It's about improvements in proc-macro2::Span: earlier it haven't had all the info necessary to highlight all the parts of a complex type at once on stable but it seems they now have some magic on nightly that allows it.

We have multiple ways to address this issue

• We could test cargo build but not cargo test on nightly - if it works on stable it probably should work on nightly. We may roll things back once they're settled out.
• We could use

  allow_failures:
      - rust: nightly
  
  in travis.yml and roll back when it's fixed.
• We could make different test cases for stable and nightly - waste of efforts if you ask me, but I still would do it if you want.

I leave it at your discretion, tell me what you think and I'll update the PR

[CreepySkeleton]

@TeXitoi So what do we do about it? I suggest allow_failure or "separate test suits for stable and nightly" solutions: both are easy to implement and unroll when needed

[TeXitoi]

Sorry. Can we do failure only on stable? That would be perfect. Else, let's do tests only on stable, as it will pose problems later when the release train change if we just allow failure on nightly.

[TeXitoi]

"failure only on stable" I mean ui tests only on stable.

[CreepySkeleton]

I'm not sure I understand you correctly, are you're saying you want not to run ui tests on nightly but run all the other tests? If yes, that's exactly what's in this PR now.

[CreepySkeleton]

@TeXitoi Unfortunately, this is not all sunshine and bubbles. clap implicitly depends on failure and failure_derive crates, and they in turn depend on old (pre 1.*) versions of quote/proc_macro2/syn crates (they are in the process of updating though). So now we have to double-build syn/proc_macro2/quote crates. Let's wait for a few days before merging this (I'll poke these guys tomorrow and I'll offer my help to speed up things)

[CreepySkeleton]

By the way, it seems like nightly feature is obsolete:

https://github.com/alexcrichton/proc-macro2/blob/75972f61403c6cc453608f3358cbfdef6edea4b5/Cargo.toml#L39

[TeXitoi]

We can remove the nightly feature.

[CreepySkeleton]

@TeXitoi This seems complete. You can merge it once people manage to update their deps

[TeXitoi]

As removing the nightly feature is a breaking change, we must merge this before 0.3. I don't really care if for now the user need to compile 2 times syn and quote as using the 1 version is the thing to do and the update of the deps will be transparent.

Can you update the changelog about the removal of the nightly feature, and I'll merge this.

[TeXitoi]

I'm OK to merge this now if you update the changelog in the other PR.

[TeXitoi]

Thanks!