Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between state and config in properties #80

Open
rjcorwin opened this issue Sep 16, 2019 · 0 comments
Open

Distinguish between state and config in properties #80

rjcorwin opened this issue Sep 16, 2019 · 0 comments
Milestone

Comments

@rjcorwin
Copy link
Contributor

Currently a there is a bit of confusion between state and config all mixed up in Polymer Properties. Attributes such as name, label, error-message, and others are configuration where as value, disabled, and hidden are state. Both state and configuration use the HTML Element attributes system, often the Polymer Properties system as a helper. This is confusing not only for knowing how to use the API of inputs, it also results in configuration such as label getting mixed up in the form responses because of the use of Element.getProps()/Element.setProps(props) will snatch/set anything listed in Polymer Properties. Not only do we not need label in the Form Response data, if that label is configured to something new in the HTML, when resuming a form the old label caught up in the Form Response will be applied to that input as if it was state. In some situations this is a feature not a bug, but most often an unexpected side affect.

@rjcorwin rjcorwin added this to the v5.0.0 milestone Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant