New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tracked queries the default #2922
Comments
I'll give this one a go! |
Would you prefer these be together in 1 PR or 2 separate PRs (one for making "tracked" the default and another for removing |
You can do both in one PR if you like :) |
For the default behavior for useQuery('key', queryFn) === useQuery('key', queryFn, {notifyOnChangeProps: "tracked"}) |
exactly. we can set the default value for
in any case, we should keep the additional array notation so that users can define the keys they want to observe. |
currently,
notifyOnChangeProps
defaults toundefined
, but many people have already stated that thetracked
version would be what they'd see as "expected"also: remove
notifyOnChangePropsExclusion
The inverse array doesn't really give you much given that you can just use tracked queries. Also, it "breaks" every time we add a new property that changes often.
For example, we have recently added a
isRefeching
computed flag to the queryResult, and since this is based onisFetching
, people that have excludedisFetching
would now get their re-renders again.The text was updated successfully, but these errors were encountered: