Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Do not end up in workspace and preview for default requests #536

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Do not end up in workspace and preview for default requests #536

wants to merge 1 commit into from

Conversation

DanielSiepmann
Copy link
Contributor

Default requests won't have a workspace id.
That will lead to TYPO3 defaults -99 id.
That in turn will lead to being in preview mode once a backend user is provided within context.

We therefore cover the default and turn it into live workspace which could be the expected default.

Resolves: #535

@DanielSiepmann DanielSiepmann marked this pull request as draft January 30, 2024 07:57
@oliverklee
Copy link
Contributor

Should this only go into the main branch, or would it make sense to backport it to 7.x as well?

@DanielSiepmann DanielSiepmann marked this pull request as ready for review February 14, 2024 12:28
@DanielSiepmann
Copy link
Contributor Author

I'm fine with both. I personally need this in one project where we apply this as a patch.
I'd leave this up to the maintainer to decide.

@DanielSiepmann
[BUGFIX] Properly initialize backend user for requests
c1cf194 
Default requests won't have a workspace id.
That will lead to TYPO3 defaults -99 id.
That in turn will lead to being in preview mode once a backend user is
provided within context.

We therefore cover the default and turn it into live workspace which
could be the expected default.

Also we add missing initialization for backend user.

Resolves: TYPO3#535
@sbuerk
Copy link
Collaborator

sbuerk commented Feb 21, 2024

If I run full core functional testsuite (with your original change and also my adoption) i get 4 failures:

$ Build/Scripts/runTests.sh -s functional

1) TYPO3\CMS\Core\Tests\Functional\DataScenarios\Regular\WorkspacesPublish\ActionTest::hideContent
Failed asserting that response has records.
* Section "Default": Could not assert all values for "tt_content.header": Regular Element #2

/var/www/work/t3c/core-main/core-main/typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/ActionTest.php:105

2) TYPO3\CMS\Core\Tests\Functional\DataScenarios\Regular\WorkspacesPublish\ActionTest::hideContentAndMoveToDifferentPage
Failed asserting that response has records.
* Section "Default": Could not assert all values for "tt_content.header": Regular Element #2

/var/www/work/t3c/core-main/core-main/typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublish/ActionTest.php:133

3) TYPO3\CMS\Core\Tests\Functional\DataScenarios\Regular\WorkspacesPublishAll\ActionTest::hideContent
Failed asserting that response has records.
* Section "Default": Could not assert all values for "tt_content.header": Regular Element #2

/var/www/work/t3c/core-main/core-main/typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/ActionTest.php:100

4) TYPO3\CMS\Core\Tests\Functional\DataScenarios\Regular\WorkspacesPublishAll\ActionTest::hideContentAndMoveToDifferentPage
Failed asserting that response has records.
* Section "Default": Could not assert all values for "tt_content.header": Regular Element #2

/var/www/work/t3c/core-main/core-main/typo3/sysext/core/Tests/Functional/DataScenarios/Regular/WorkspacesPublishAll/ActionTest.php:128

so I guess we need more investigation there first. Will have a more detailed look later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbuerk sbuerk sbuerk left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BackendUserHandler breaks workspace
3 participants
@DanielSiepmann @oliverklee @sbuerk