Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all current deprecations #909

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Remove all current deprecations #909

merged 1 commit into from
Jul 12, 2022

Conversation

codecholeric
Copy link
Collaborator

Since we are about to release a new major version we can finally throw out all existing deprecations.

Since we are about to release a new major version we can finally throw out all existing deprecations.

Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
@codecholeric codecholeric merged commit 5299db6 into main Jul 12, 2022
@codecholeric codecholeric deleted the remove-deprecations branch July 12, 2022 12:16
@perlun
Copy link
Contributor

perlun commented Feb 7, 2023

If you're unlucky like me, you might have been using a really-old version like 0.14.1 where methods like JavaClass.namesOf() wasn't even deprecated yet. 😁 This was a bit confusing in the upgrade. Luckily. git clone git@github.com:TNG/ArchUnit.git and looking at the git log -p ./archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClass.java output made it fairly simple to see what the method was replaced with.

(Hint: Use Formatters.formatNamesOf() or look at the diff to see the full details here)

It might even be worth suggesting for people still stuck on the 0.x versions to first upgrade to https://github.com/TNG/ArchUnit/releases/tag/v0.23.1 before attempting the 1.0.x upgrade, since that will highlight all deprecations. That would probably have helped me. 🤔 I didn't realize it until now though.


(Btw, big thanks for doing your very best to try and apply SemVer correctly! Can't tell you how much that means to me. 🙏 Greatly appreciated!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants