Add is annotation to JavaClass and fluent API
#468
Merged
+277
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since I always have a hard time to identify which tests really have failed on the console (either Gradle just reports something like '3 tests failed' without any details, or it prints out so many details that the test results get lost) I have added some quick hack to print out some sort of test failure report in the end. It is not integrated in a very sophisticated way, but I consider it good enough at the moment, since the reporting might change with future Gradle versions again anyway and the logic responsible for collecting and printing the report at least is contained in one isolated place. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
The bytecode provides the opcode `ACC_ANNOTATION` which denotes those classes that are annotations (e.g. the annotation type of `@Deprecated`). Same as for the Java Reflection API (which offers `Class.isAnnotation()`) we should provide this information through `JavaClass`. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
To be consistent with `isEnum` we should also provide `that` and `should` syntax elements for `isAnnotation` in the fluent API to allow easily specifying rules about annotation types. Signed-off-by: Peter Gafert <peter.gafert@tngtech.com>
codecholeric
force-pushed
the
add-isAnnotation-to-JavaClass-and-fluent-API
branch
from
f5cc6b5 to
dafafab
Compare
codecholeric
added a commit
that referenced
this pull request
Feb 21, 2021
The bytecode provides the opcode `ACC_ANNOTATION` which denotes those classes that are annotations (e.g. the annotation type of `@Deprecated`). Same as for the Java Reflection API (which offers `Class.isAnnotation()`) we should provide this information through `JavaClass`. Furthermore we should expose this information through the fluent API to allow easy creation of `ArchRules` about annotation types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bytecode provides the opcode
ACC_ANNOTATIONwhich denotes those classes that are annotations (e.g. the annotation type of@Deprecated). Same as for the Java Reflection API (which offersClass.isAnnotation()) we should provide this information throughJavaClass.Furthermore we should expose this information through the fluent API to allow easy creation of
ArchRulesabout annotation types.