Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types defined in subpackages are treated as valid types #1529

Closed
matt2e opened this issue May 17, 2024 · 0 comments · Fixed by #1530
Closed

types defined in subpackages are treated as valid types #1529

matt2e opened this issue May 17, 2024 · 0 comments · Fixed by #1530
Assignees

Comments

@matt2e
Copy link
Contributor

matt2e commented May 17, 2024

Steps:

  • Make a module called parent
  • Make a subpackage within the module called child
package child

type ChildStruct struct {
  Name string
}
  • In parent, use this type
//ftl:data
type ParentResponse struct {
  Message string            `json:"message"`
  Data    child.ChildStruct `json:"data"`
}

Expected:

An error saying you can't use types from subpackages

Actual result:

schema:

data ParentResponse {
  message String +alias json "message"
  data parent.ChildStruct +alias json "data"
}

Not only is it not making an error when extracting the schema, the type parent.ChildStruct doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant