Symfony 6 support #13274
Labels
DX
Issues and PRs aimed at improving Developer eXperience.
Enhancement
Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Maintenance
CI configurations, READMEs, releases, etc.
Comments
|
Pagerfanta got release |
|
SyliusGridBundle: Sylius/SyliusGridBundle#192 (but requires also: SyliusLabs/PolyfillSymfonyEventDispatcher#1) |
|
friendsofsymfony/rest-bundle 🦀 FriendsOfSymfony/FOSRestBundle#2340 GridBundle also requires Sylius/SyliusGridBundle#143 before Sylius/SyliusGridBundle#192 can land (I'm not making PagerfantaBundle 2.x compatible with Symfony 6) |
|
thanks @mbabker I edited the first post to update the informations. |
|
We have now:
|
|
@stloyd thx, I updated the first post |
Zales0123
added
DX
This was referenced May 13, 2022
Merged
This was referenced Jul 19, 2022
lchrusciel
added a commit
that referenced
this issue
Jul 19, 2022
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | master | Bug fix? | yes (for Symfony 6) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 1719db4 Fix deletion listeners 6b2f095 Improve deprecations\' messages 4d62e37 Use request stack on Phpspec tests 974e3f1 Trying to fix HomepageContext
lchrusciel
added a commit
that referenced
this issue
Jul 22, 2022
This PR was merged into the symfony-6 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | symfony-6 | Bug fix? | yes (for Symfony 6) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> And it\'s fixed here https://github.com/Sylius/Sylius/runs/7464954762?check_suite_focus=true Commits ------- 330f33c [PayumBundle] Add support for Symfony 6
lchrusciel
added a commit
that referenced
this issue
Jul 22, 2022
…ic425) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | 1.12 | Bug fix? | yes (for Symfony 6) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 7549b44 Fix order customer ip listener
This was referenced Jul 22, 2022
Zales0123
added a commit
that referenced
this issue
Jul 25, 2022
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | 1.12 | | Bug fix? | yes (for Symfony 6) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> The static create method was deprecated on Symfony 5 and has been removed on Symfony 6. Commits ------- 9024f9c Fix notification controller
Zales0123
added a commit
that referenced
this issue
Jul 25, 2022
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | 1.12 | Bug fix? | yes (for Symfony 6) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Before  After  Commits ------- 05ac623 Fix requeset password reset action spec
lchrusciel
added a commit
that referenced
this issue
Jul 25, 2022
… (loic425) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | 1.12 | Bug fix? | yes | New feature? | no | BC breaks? | not sure | Deprecations? | no/ | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Not sure about BC break I removed the dependency of the removed service https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Security/Http/Logout/DefaultLogoutSuccessHandler.php Commits ------- 904481f Fix shop user logout handler afe5ad9 Don\'t invalidate sessions 15e8cff Remove getSubscribedEvents
GSadee
added a commit
that referenced
this issue
Aug 9, 2022
…rusciel) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | 1.12 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | partially #13274 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.11 branch - Features and deprecations must be submitted against the 1.12 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- ee8146c [Maintenance] Bump JMS/Serializer-Bundle dependency
This was referenced Aug 23, 2022
lchrusciel
added a commit
that referenced
this issue
Aug 24, 2022
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | 1.12 | Bug fix? | yes (for SF6) | New feature? | no | BC breaks? | no | Deprecations? | no <!-- don\'t forget to update the UPGRADE-*.md file --> | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.11 branch - Features and deprecations must be submitted against the 1.12 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- f34bc4f Fix getting criteria
lchrusciel
added a commit
that referenced
this issue
Aug 24, 2022
This PR was merged into the 1.12 branch. Discussion ---------- | Q | A |-----------------|-------------------------------------------------------------- | Branch? | 1.12 | Bug fix? | yes (for SF6) | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | partially #13274 | License | MIT <!-- - Bug fixes must be submitted against the 1.11 branch - Features and deprecations must be submitted against the 1.12 branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 3cd4554 Fix getting route params
GSadee
added a commit
that referenced
this issue
Sep 14, 2022
…oic425, Zales0123) This PR was merged into the symfony-6 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | symfony-6 | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | replaces #14183, contributes to #13274 | | License | MIT | The goal of this PR is to make the whole Sylius installable (not working yet!) with Symfony 6 packages. Packages builds are already working after #14287, #14284 and #14285. The next steps would be fixing static checks and PHPSpec, Behat tests are waiting for #14283 🖖 Commits ------- 7686374 Use UserNotFound exception 140d2ac Checking package versions f0c6234 Fix packages versions bbf077c Fix packages versions for doctrine/dbal a436cbb Upgrade main packages to allow Symfony 6 ef011a5 Do not remove conflict but adjust versions 88215a9 Bump knplabs/gaufrette dependency a36895f Delete unneeded swiftmailer file 1369d6e Hot-fix with symfony mockery container dc92fa2 Bump mailer bundle dependencies ef390c1 Make all dependencies consistent e5e4e16 Update some Sylius packages dependencies 49aadc8 Remove unneedd conflicts
Zales0123
added a commit
that referenced
this issue
Sep 23, 2022
This PR was merged into the symfony-6 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | symfony-6 <!-- see the comment below --> | | Bug fix? | no | | New feature? | no | | BC breaks? | no | | Deprecations? | no <!-- don't forget to update the UPGRADE-*.md file --> | | Related tickets | contributes to #13274 | | License | MIT | Commits ------- b26c90b Fix static checks for Symfony 5.4 426073a [WIP] Fix static checks on Symfony 6 35dfe87 Fix static checks on symfony 6 - continuation
|
I've upgrade the issue description with |
GSadee
added a commit
that referenced
this issue
Oct 4, 2022
…ales0123) This PR was merged into the symfony-6 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | symfony-6 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | contributes to #13274 | | License | MIT | ~I've disabled most of the build and left only one Behat build for Symfony 6 to speed up the feedback loop 💃~ EDIT: all of them returned 🚀 ~As far as I see, the most important problem right now is the `PathPrefixProvider` service, which uses the `UserContext`... which cannot resolve the AdminUser in admin scenarios :| Hopefully, I will manage to fix it soon, and then I will restore the rest of the builds 🖖~ EDIT: see [this comment](#14376 (comment)) Commits ------- 48ad197 [Behat] Add session hook context e284329 Temporarily run only features/account/ Behat scenarios in Symfony 6 4333279 Fix Behat scenarios for User account ee6fef0 Composer.json fixes e4fc0b7 Enable some Behat scenarios build 57d4e6c Remove some deprecations to fix most of Behat scenarios e90c4d8 Do not reset token storage between tests 4c5f540 Make IriConverter stateless bb2970d Return the whole application build 2b2502d Return temporarily removed workflows 90139b0 Remove duplicated code in CachedRouteNameResolver 4e99f9e Remove duplicated code in Symfony6PrivateServicesPass
Zales0123
pushed a commit
to Zales0123/Sylius
that referenced
this issue
Oct 4, 2022
…ate, Zales0123) This PR was merged into the symfony-6 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | symfony-6 | | Bug fix? | yes | | New feature? | no | | BC breaks? | no | | Deprecations? | no | | Related tickets | contributes to Sylius#13274 | | License | MIT | ~I've disabled most of the build and left only one Behat build for Symfony 6 to speed up the feedback loop 💃~ EDIT: all of them returned 🚀 ~As far as I see, the most important problem right now is the `PathPrefixProvider` service, which uses the `UserContext`... which cannot resolve the AdminUser in admin scenarios :| Hopefully, I will manage to fix it soon, and then I will restore the rest of the builds 🖖~ EDIT: see [this comment](Sylius#14376 (comment)) Commits ------- 48ad197 [Behat] Add session hook context e284329 Temporarily run only features/account/ Behat scenarios in Symfony 6 4333279 Fix Behat scenarios for User account ee6fef0 Composer.json fixes e4fc0b7 Enable some Behat scenarios build 57d4e6c Remove some deprecations to fix most of Behat scenarios e90c4d8 Do not reset token storage between tests 4c5f540 Make IriConverter stateless bb2970d Return the whole application build 2b2502d Return temporarily removed workflows 90139b0 Remove duplicated code in CachedRouteNameResolver 4e99f9e Remove duplicated code in Symfony6PrivateServicesPass
Zales0123
added a commit
that referenced
this issue
Oct 7, 2022
…, GSadee, coldic3) This PR was merged into the 1.12 branch. Discussion ---------- | Q | A | |-----------------|--------------------------------------------------------------| | Branch? | master | | Bug fix? | no | | New feature? | yes | | BC breaks? | hope no | | Deprecations? | no | | Related tickets | fixes #13274 | | License | MIT | <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 4f5040f [Maintenance] Update routings' `controller` node syntax 4292d52 Skip tests that cannot be fixed now 1b5e74d Extract session management in tests a8f8b71 Revert SyliusLabs/PolyfilSymfonySecurity fork branch 0de67b7 [Maintenance] Support both UserPasswordEncoder & UserPasswordHasher c4e08e4 [Maintenance] PasswordUpdater supports both Symfony 5.4 & Symfony 6 e585559 [Maintenance] psalm.xml updated with deprecated class and interface 5bd0839 Use Symfony Mailer by default 8ffa91d [Test] Refactor EmailChecker to work with Symfony Mailer 04963ce [Maintenance] Transform email html content to text 3d2fafd [Maintenance] Update email assertion in Unit tests ab61828 [Maintenance] Remove Swiftmailer-based unit tests 23eda82 [Maintenance] Updated mailer config 3f47138 [Maintenance] Move EmailChecker from Core into Behat 1efe040 [Behat] Fix SecurityService to work with new session management flow e8c1f5f [Behat] Add session hook context bd261c4 [Maintenance][Behat] Temporarily allow failing cli tests 254682f [Maintenance] Bring back swiftmailer-based tests in packages 4253917 [Maintenance] Fix test apps configuration for swiftmailer env 2e47204 [Behat] Add session hook context 26a7da8 Temporarily run only features/account/ Behat scenarios in Symfony 6 c814085 Fix Behat scenarios for User account 129974b Composer.json fixes 05ee163 Remove some deprecations to fix most of Behat scenarios 868c503 Do not reset token storage between tests 368a280 Make IriConverter stateless 011ad0b Return the whole application build 7fd70d0 Return temporarily removed workflows fadbe0d Remove duplicated code in CachedRouteNameResolver 50e2967 Remove duplicated code in Symfony6PrivateServicesPass 3a5b69d [ProductAttribute] The way of processing query parameters changed 11b9fc2 [GithubActions] Redundand Run JS Behat command removed 85f180f [Forms] Legacy error messages disabled 74f599b [Promotions][Behat] Form validation message changed according to the new messaging system 1f43b43 [Behat] Unused step implementation removed 5a53028 [CatalogPromotions][API][Behat] Step with a different behavior in SF-5.4 and SF-6 changed d7448f2 [Behat][API][Admin] Proper IRIs in the admin context bc7abda Fix encore build for AdminBundle and CoreBundle 1bcbb48 Fix packages versions 7ee060c Remove unneeded ApiPlatform version check in static checks da97c99 Fix deprecated controller syntax to fix the build d321bee [Github Actions] Make timeout for non-JS build longer e95b96f bug #14414 [Github Actions] Make timeout for non-JS build longer (Zales0123) a49d879 [Symfony 6] Remove setting services for test as public 90de5a2 bug #14407 [Symfony 6] Remove setting services for test as public (Zales0123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Internal Packages
Internal Bundle
Internal PRs
Sylius technical packages
External Packages
Final fixes left:
symfony-6branch with 1.12 to upgrade the main PRThe text was updated successfully, but these errors were encountered: