Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cache Details documentation #49

Merged
merged 1 commit into from Mar 5, 2022

Conversation

edmorley
Copy link
Contributor

@edmorley edmorley commented Mar 4, 2022

Thank you for a great tool!

This updates the documentation on how the cache works to more closely match the implementation and to explain some of the design decisions.

In addition, I've made a few wording/detail tweaks based on questions I had when first using this action, that had to be answered by source code inspection. (For example: "is the cache key only based off of the repo root Cargo.toml / Cargo.lock or all such files in the repository, including subdirectories?".)

@edmorley edmorley force-pushed the cache-details-docs branch 2 times, most recently from bd27dbc to f0a8341 Compare March 4, 2022 16:00
Updates the documentation on how the cache works to more
closely match the implementation and to explain some of the design decisions.
Copy link
Owner

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

hey @edmorley 👋🏻 long time no see ;-)

@Swatinem Swatinem merged commit 5b2b053 into Swatinem:v1 Mar 5, 2022
@edmorley edmorley deleted the cache-details-docs branch March 6, 2022 09:07
@edmorley
Copy link
Contributor Author

edmorley commented Mar 6, 2022

Indeed! Hope you are well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants