Allow overriding AcsCommand handling

[jnivala]

Hi all,

I am using Sustainsys.Saml2.AspNetCore2 with IdentityServer v4. I had to handle Saml2Responses whose Status != Saml2StatusCode.Success. Our Idp generates those when user cancels logon.

To achieve the result, I implemented a customized Saml2Handler. As Saml2Handler.HandleRequestAsync is not virtual, I could not override it. Instead I had to wrap original Saml2Handler inside my custom implementation.
=> It would be nice if Saml2Handler.HandleRequestAsync was virtual.

Even cooler would be if the library would allow resolving CommandFactory as service. In case no service existed, then the library would use default implementation. IdentityServer uses this pattern to allow injecting e.g. your own IProfileService and IClaimsService.

Then there is some helper code that would be useful as public. E.g. HttpRequestExtensions and CommandResultExtensions.

Regards.

[jnivala]

Hi again,

I added PR 1131 that contains the mentioned changes. I look forward for maintainers to review the PR.

Regards,
Janne

[AndersAbel]

As commented on the PR, this is not something that will be implemented in the 2.X branch. There are plans for a 3.X version that is Asp.NET Core only and would be integrated with the DI system.

[rpmansion]

@AndersAbel any specific date for your 3.X version plans?

[AndersAbel]

My intention is that the upcoming 2.5.0 should be the last 2.X feature release and that work will then commence with the new on. But it depends both on how much time I can set aside and if I get any more contributors helping out with the work.

[rpmansion]

@AndersAbel I can use some free time to help :)