Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding color to supervisor ? #1360

Closed
yashmehrotra opened this issue Jul 23, 2020 · 2 comments
Closed

Adding color to supervisor ? #1360

yashmehrotra opened this issue Jul 23, 2020 · 2 comments

Comments

@yashmehrotra
Copy link

I was playing around with supervisor and added tabulation and color in my own fork.

Would you all be interested in something like this ? If you are, I will update my fork and create a PR for this (and make any changes if required)

Image

Ref: https://yashmehrotra.com/post/2018-02-25-coloring-supervisor/

@mnaberez
Copy link
Member

Hi, thanks for this offer and suggestion. I do not think we can use your fork because we do not want to add the package dependencies on tabulateand such. However, we have an open pull request (#530) that does pretty much the same without these packages. I am not sure why we have not merged it yet (maybe it needed tests, docs, or something minor) but it is open and should get merged eventually. If you are up for it, please try that patch also and leave a comment there if you find any issues with it. Thanks!

@yashmehrotra
Copy link
Author

@mnaberez Sure, I understand your concern. The extra packages was the reason I didn't create a PR in the first place.
Thanks for pointing me to the patch, will take a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants