Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove axios from dependencies due to reported security vulnerability causing false alert #78

Closed
erikeckhardt opened this issue May 30, 2019 · 6 comments

Comments

@erikeckhardt
Copy link

erikeckhardt commented May 30, 2019

Vulnerability CVE-2019-10742 in npm package axios has been identified in the National Vulnerability Database.

Axios up to and including 0.18.0 allows attackers to cause a denial of service (application crash) by continuing to accepting content after maxContentLength is exceeded.

Because axios is still listed in dependencies of js-sumo-logger, code depending on js-sumo-logger is getting flagged as having a security vulnerability.

This issue is thus for tracking removing axios from the dependency.

For more information from the axios side:

erikeckhardt added a commit to erikeckhardt/js-sumo-logger that referenced this issue May 30, 2019
erikeckhardt added a commit to erikeckhardt/js-sumo-logger that referenced this issue May 30, 2019
erikeckhardt added a commit to erikeckhardt/js-sumo-logger that referenced this issue May 30, 2019
- Due to vulnerability CVE-2019-10742
- See issue SumoLogic#78 for details
@erikeckhardt
Copy link
Author

I have submitted PR #79 to fix this issue.

@billsaysthis
Copy link
Contributor

Thanks @erikeckhardt but we are removing Axios in favor of SuperAgent. Not sure why the line for Axios was left in the package but I will file a new PR removing it shortly.

erikeckhardt added a commit to erikeckhardt/js-sumo-logger that referenced this issue May 30, 2019
- Was replaced with SuperAgent
- Due to vulnerability CVE-2019-10742 causing package managers and github to trigger a security alert
- See issue SumoLogic#78 for details
@erikeckhardt
Copy link
Author

That's a perfectly acceptable solution. Just for convenience, I've updated my PR to remove that as well, if you feel like merging it.

@erikeckhardt erikeckhardt changed the title axios security vulnerability Remove axios from dependencies due to reported security vulnerability causing false alert May 30, 2019
@billsaysthis
Copy link
Contributor

Removed Axios in #80.

@erikeckhardt
Copy link
Author

Ah, I see you've already created and merged your own. Pity, as I could easily have updated my PR for you. Thanks for taking care of it!

Do you expect a patch release soon?

@billsaysthis
Copy link
Contributor

Yes, just triggered the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants