Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two close buttons displayed on edit history window #1204

Open
Geeyun-JY3 opened this issue Aug 2, 2020 · 5 comments
Open

Two close buttons displayed on edit history window #1204

Geeyun-JY3 opened this issue Aug 2, 2020 · 5 comments
Labels
bug 🐛 Something isn't working github :octocat:

Comments

@Geeyun-JY3
Copy link

Geeyun-JY3 commented Aug 2, 2020

  • Browser: Cent Browser 4.2.10.171 (64-bit) (Chromium 80.0.3987.163), Chrome 84.0.4147.89 (Official Build) (64-bit)
  • Operating System: Windows 10 1909
  • Link to page with the issue: any page
  • Screenshot:
    testimage
@Geeyun-JY3 Geeyun-JY3 added the bug 🐛 Something isn't working label Aug 2, 2020
@xt0rted
Copy link
Member

xt0rted commented Aug 2, 2020

The base html has 2 buttons which might be a bug on GitHub's end. This rule changes the box header size which causes the second one to become visible:

.Box-header, .Box-row, .Box-body {
  padding: 8px 12px;
}

@silverwind 9ecd373 caused this issue.

@silverwind
Copy link
Member

Any link to a page containing this?

@Geeyun-JY3
Copy link
Author

@silverwind I have edited this issue.

@silverwind
Copy link
Member

Ah I see, should have mentioned issue. I was thinking wiki.

@silverwind
Copy link
Member

silverwind commented Aug 2, 2020

This is a hard one. If we hide one button, we risk having none appear after this issue is fixed. Certainly a GitHub bug but only visible with our padding tweak, otherwise the two buttons overlap exactly.

@silverwind silverwind added github :octocat: bug 🐛 Something isn't working and removed bug 🐛 Something isn't working labels Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working github :octocat:
Projects
None yet
Development

No branches or pull requests

3 participants