Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSZipGeneratorOptions.encodeFileName declaration changed #833

Open
chrisxvin opened this issue Jun 14, 2022 · 0 comments · May be fixed by #883
Open

JSZipGeneratorOptions.encodeFileName declaration changed #833

chrisxvin opened this issue Jun 14, 2022 · 0 comments · May be fixed by #883

Comments

@chrisxvin
Copy link

chrisxvin commented Jun 14, 2022 •
edited

In the document, encodeFileName is described as "The function takes a string and returns a bytes array (Uint8Array or Array)", but in .d.ts file, it's declared as encodeFileName?(filename: string): string;, and cannot use code from the doc.

I'm confused now...How can I encode file name correctly? Thanks.
@chrisxvin chrisxvin changed the title encodeFileName declaration changed JSZipGeneratorOptions.encodeFileName declaration changed Jun 14, 2022
@skyt-a skyt-a linked a pull request Jan 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typescript definitions: Fix return type of JSZipGeneratorOptions.encodeFileName skyt-a/jszip
1 participant
@chrisxvin