Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use libc's definitions where possible #26

Merged
merged 1 commit into from Nov 29, 2022
Merged

Use libc's definitions where possible #26

merged 1 commit into from Nov 29, 2022

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Nov 29, 2022

This not only reduces total code size (since xattr already depends on libc anyway), but also leverages libc's CI to ensure that the FFI bindings are correct.

@asomers
Use libc's definitions where possible
33d0210 
This not only reduces total code size (since xattr already depends on
libc anyway), but also leverages libc's CI to ensure that the FFI
bindings are correct.
Stebalien
Stebalien approved these changes Nov 29, 2022
View reviewed changes
Copy link
Owner

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit 48791d8 into Stebalien:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asomers @Stebalien