Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove byteorder-dependency #98

Merged
merged 1 commit into from Aug 5, 2019
Merged

Remove byteorder-dependency #98

merged 1 commit into from Aug 5, 2019

Conversation

lukaslueg
Copy link
Contributor

This removes the byteorder-dependency, which is unneeded since 1.32 and gets pulled in a lot due to term.

Stebalien
Stebalien approved these changes Aug 4, 2019
View reviewed changes
Copy link
Owner

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the nit about field punning. Could you revert that change?

src/terminfo/mod.rs Outdated Show resolved Hide resolved
@lukaslueg
Copy link
Contributor Author

I took liberty to rebase and force-push

Stebalien
Stebalien approved these changes Aug 5, 2019
View reviewed changes
Copy link
Owner

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit c6277a1 into Stebalien:master Aug 5, 2019
@Stebalien
Copy link
Owner

Published so you can remove the dep.

@lukaslueg lukaslueg deleted the byteorder_removed branch August 5, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukaslueg @Stebalien