Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edition 2018 #96

Merged
merged 7 commits into from Jul 25, 2019
Merged

Edition 2018 #96

merged 7 commits into from Jul 25, 2019

Conversation

fkohlgrueber
Copy link
Contributor

Hi,

this PR updates term to edition 2018. I've also used clippy and rustfmt to fix smaller issues.

Please let me know if there are issues within the changes I made. Thanks in advance ;-)

Copy link
Owner

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits, otherwise, LGTM.

src/terminfo/mod.rs Outdated Show resolved Hide resolved
src/terminfo/mod.rs Outdated Show resolved Hide resolved
src/terminfo/parm.rs Outdated Show resolved Hide resolved
@fkohlgrueber
Copy link
Contributor Author

Ok, I've updated the PR. I renamed #dyn to dyn_vars and sta to sta_vars for consistency. Hope that's ok for you.

Copy link
Owner

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Stebalien Stebalien merged commit beeb40d into Stebalien:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants