Don't set FILE_ATTRIBUTE_HIDDEN #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI builds are failing due to Edit: I made separate a fix for that in PR #77. |
If this attribute is set, we cannot close and reopen the file and then
write to it. Attempting to open the file a second time in write mode
results in `ERROR_ACCESS_DENIED`.
For reference, see the CreateFile MSDN docs:
If CREATE_ALWAYS and FILE_ATTRIBUTE_NORMAL are specified, CreateFile
fails and sets the last error to ERROR_ACCESS_DENIED if the file
exists and has the FILE_ATTRIBUTE_HIDDEN or FILE_ATTRIBUTE_SYSTEM
attribute. To avoid the error, specify the same attributes as the
existing file.
Stebalien
approved these changes
Dec 28, 2018
|
@jasonwhite Thanks so much for fixing this! @Stebalien any chance we could get a 3.0.6 release with this fix? |
|
@bolinfest done. |
|
@Stebalien thanks for the fast work: this fixes what was a frustrating issue for us! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this attribute is set, we cannot close and reopen the file and then
write to it. Attempting to open the file a second time in write mode
results in
ERROR_ACCESS_DENIED.For reference, see the CreateFile MSDN docs:
Fixes #69.
Fixes #66.
Alternative to #67.