replace rand with fastrand #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @joshuarli. Thanks for implementing this and sorry for making you implement the SmallRng version. I figured I'd take advantage of the fact that I've been an absentee maintainer to reconsider this decision before releasing 3.3.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opens #118.
At the time the PR was submitted, fastrand was new. But it's been a year now since we switched to
SmallRng and it's still going strong.
While this will slightly increase the build size for crates already depending on rand, fastrand is
really small and has no direct dependencies.
Security: Neither Go nor Python's tempfile name generator use cryptographic randomness, so I'm feeling pretty comfortable sticking with non-cryptographic randomness here.