Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: New namespace + name generation #1917

Open
wg102 opened this issue Dec 13, 2023 · 11 comments
Open

2.0: New namespace + name generation #1917

wg102 opened this issue Dec 13, 2023 · 11 comments
Assignees
Labels
aaw2.0 tasks and epics specific for the platform

Comments

@wg102
Copy link
Contributor

wg102 commented Dec 13, 2023

New feature for AAW 2.0

-> When a new user logs in for the first time, show the 'create a namespace' pop up.
-> Generate the username based on firstname-lastname(possible digit if it already exists)

See #1909, possibly make code so it detects a specific username for now, since testing without a namespace might be harder. It will need to be tested for the number feature regardless.

(ref 1).
ref 2

@wg102 wg102 added the aaw2.0 tasks and epics specific for the platform label Dec 13, 2023
@wg102 wg102 self-assigned this Dec 13, 2023
@wg102
Copy link
Contributor Author

wg102 commented Dec 13, 2023

Note: Use a "Next: button instead.
Where is the email gonna validate

@wg102
Copy link
Contributor Author

wg102 commented Dec 14, 2023

template(is='dom-if', if='[[registrationFlow]]') this is what defines if the popup shows. I will disable it for now, since this is not what I want to test, but I want to modify the landing-page(user-details='[[_extractLdap(user)]]' on-flowcomplete='resyncApp', language='[[language]]', resources='[[resources]]')

@wg102
Copy link
Contributor Author

wg102 commented Dec 14, 2023

The page was removed on this commit StatCan/kubeflow@befdcc0 during the 1.7 upgrade.

Now that I found this, I can find when we had the create function as well

@chuckbelisle chuckbelisle mentioned this issue Dec 15, 2023
9 tasks
@wg102
Copy link
Contributor Author

wg102 commented Dec 18, 2023

First idea for wizard text:

Welcome

This seems to be the first time you access Kubeflow!
We are happy to see you

The email you are using is:
(input with the email - readonly)

Your namespace will be
(input with namesapce - readonly)

If you have questions or issues, please contact our Slack support channel at https://statcan-aaw.slack.com

[Next button]

@wg102
Copy link
Contributor Author

wg102 commented Dec 18, 2023

Current slight issue with the md2-input, it has a property to handle disabled, but it was never added to the UI, hence why it never triggered. see here Now I just need to edit the pug code of upstream (in our repo) to most likely fix this issue. Once that is dealt with, the algorithm is next, to generate the name

@wg102
Copy link
Contributor Author

wg102 commented Dec 20, 2023

The current visuals is looking like this:
image

@wg102
Copy link
Contributor Author

wg102 commented Jan 3, 2024

image
French has not being translated, so it's a bit glitchy.

@wg102
Copy link
Contributor Author

wg102 commented Jan 3, 2024

The visual for French looks right,
image

but the button is having trouble

@wg102
Copy link
Contributor Author

wg102 commented Jan 8, 2024

The code now seems to work, at least for the generation of the namespace, I did hit another issue, the api of jupyter i was calling to verify if the namespace existed will not work because of how authentication is done. jupyter/api/namespaces/${namespace}
Since when the namespace exists and you have rolebindings, you get 200, but when you don't have rolebindings you get 403, and when it does not exist, you also get 403. Therefore you cannot discern if the namespace actually exists or not if you don't have rolebindings to it, and since it's before creating the namespace, it might clash with another one.

@wg102
Copy link
Contributor Author

wg102 commented Jan 8, 2024

The issue was mostly in the Promises, it was coded wrong, and the sequence was not the best. After a few tries, I bypassed the issue by having the promise be the one setting the value to the textbox, which will only populate when the data is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aaw2.0 tasks and epics specific for the platform
Projects
None yet
Development

No branches or pull requests

1 participant