Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: *pop_non_blocking() #134

Merged
merged 4 commits into from May 11, 2022
Merged

feat: *pop_non_blocking() #134

merged 4 commits into from May 11, 2022

Conversation

laysakura
Copy link
Contributor

Fixes: #125

Keeping blocking versions and adding warning comments.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #134 (a336296) into main (fd56f7b) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   87.71%   87.88%   +0.16%     
==========================================
  Files         203      203              
  Lines       12448    12620     +172     
==========================================
+ Hits        10919    11091     +172     
  Misses       1529     1529              
Impacted Files Coverage Δ
springql-core/src/api/high_level_rs.rs 70.00% <100.00%> (+3.33%) ⬆️
springql-core/src/api/low_level_rs.rs 85.00% <100.00%> (+2.64%) ⬆️
springql-core/src/stream_engine.rs 95.65% <100.00%> (+0.65%) ⬆️
...gine/in_memory_queue_repository/in_memory_queue.rs 100.00% <100.00%> (ø)
springql-core/tests/e2e_high_level_rs.rs 100.00% <100.00%> (ø)
springql-core/tests/e2e_low_level_rs.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd56f7b...a336296. Read the comment docs.

@laysakura laysakura merged commit 286ab9d into main May 11, 2022
@laysakura laysakura deleted the fix/non-blocking-pop branch May 11, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: in-memory queue's pop must not be a blocking call
1 participant