Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove parking_lot from dependency #242

Closed
wants to merge 3 commits into from
Closed

remove parking_lot from dependency #242

wants to merge 3 commits into from

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented Sep 9, 2022 •
edited

Issue number and link

Fixes: #222

Describe your changes

  • remove parking_lot and fix compilation errors

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@kazuk
Copy link
Contributor Author

kazuk commented Sep 9, 2022

Test failes with timeout.

stoped at
https://github.com/SpringQL/SpringQL/blob/main/springql-core/src/stream_engine/autonomous_executor/main_job_lock.rs#L18

@kazuk
Copy link
Contributor Author

kazuk commented Sep 9, 2022

Lock hold sleeping
https://github.com/SpringQL/SpringQL/blob/main/springql-core/src/stream_engine/autonomous_executor/worker/worker_thread.rs#L159

@kazuk
Copy link
Contributor Author

kazuk commented Sep 9, 2022

lock holding calling main_loop_cycle

https://github.com/SpringQL/SpringQL/blob/main/springql-core/src/stream_engine/autonomous_executor/worker/worker_thread.rs#L154-L161

purger_worker sleeps in main_loop_cycle

https://github.com/SpringQL/SpringQL/blob/main/springql-core/src/stream_engine/autonomous_executor/purger_worker/purger_worker_thread.rs#L72

causes lock holding sleep

@kazuk kazuk closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove dependency to parking-lot with Rust 1.62.0
1 participant
@kazuk