Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: SourceRow::Raw(SchemalessRow) and Row -> StreamRow #211

Merged
merged 4 commits into from Jun 23, 2022

Conversation

laysakura
Copy link
Contributor

@laysakura laysakura commented Jun 23, 2022

Issue number and link

Describe your changes

Then we removed apply_new_stream_model().

Checklist before requesting a review

  • I follow the Semantic Pull Requests rules (bugfix/feature)
  • I specified links to related issues (must: bugfix, want: feature)
  • I have performed a self-review of my code (bugfix/feature)
  • I have added thorough tests (bugfix/feature)
  • I have edited ## [Unreleased] section in CHANGELOG.md following keep a changelog syntax (bugfix/feature)
  • I {made/will make} a related pull request for documentation repo (feature)

@laysakura laysakura changed the title refactor: SourceRow::Raw(SchemalessRow) refactor: SourceRow::Raw(SchemalessRow) and Row -> StreamRow Jun 23, 2022
@laysakura laysakura marked this pull request as ready for review June 23, 2022 11:14
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #211 (5dc5a53) into main (b46c6a0) will decrease coverage by 0.04%.
The diff coverage is 97.19%.

@@            Coverage Diff             @@
##             main     #211      +/-   ##
==========================================
- Coverage   84.90%   84.86%   -0.05%     
==========================================
  Files         214      215       +1     
  Lines       12523    12545      +22     
==========================================
+ Hits        10633    10646      +13     
- Misses       1890     1899       +9     
Impacted Files Coverage Δ
...ngql-core/src/stream_engine/autonomous_executor.rs 93.67% <ø> (ø)
...m_engine/autonomous_executor/row/schemaless_row.rs 87.50% <87.50%> (ø)
...tream_engine/autonomous_executor/row/stream_row.rs 96.07% <96.07%> (ø)
springql-core/src/api/spring_sink_row.rs 73.68% <100.00%> (ø)
springql-core/src/connection.rs 97.95% <100.00%> (ø)
springql-core/src/stream_engine.rs 86.36% <100.00%> (ø)
...ream_engine/autonomous_executor/queue/row_queue.rs 100.00% <100.00%> (ø)
...m_engine/autonomous_executor/queue/window_queue.rs 100.00% <100.00%> (ø)
...ne/autonomous_executor/row/column/stream_column.rs 95.33% <100.00%> (+3.96%) ⬆️
...am_engine/autonomous_executor/row/column_values.rs 73.33% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46c6a0...5dc5a53. Read the comment docs.

@laysakura laysakura merged commit 56deee0 into main Jun 23, 2022
@laysakura laysakura deleted the refactor/SchemalessRow branch June 23, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant