New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix actionlint warnings #150
Conversation
Codecov Report
@@ Coverage Diff @@
## main #150 +/- ##
=======================================
Coverage 87.81% 87.82%
=======================================
Files 203 203
Lines 12620 12620
=======================================
+ Hits 11082 11083 +1
+ Misses 1538 1537 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't you run actionlint
task in CI?
(docker-in-docker issues?)
I think the time when CI maintenance will occur frequently is about to end. If the CI processing corrections occur frequently in the future, there is a benefit to add, but if it occurs very rarely, I think that it is not necessary to run it every time. If we need a drastic correction of CI processing, we can consider adding it before doing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Issue number and link
Fixes: #151
Describe your changes
SC2086: Double quote to prevent globbing and word splitting
SC2043: This loop will only ever run once. Bad quoting or missing glob/expansion?
Checklist before requesting a review
## [Unreleased]
section inCHANGELOG.md
following keep a changelog syntax (bugfix/feature)