Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TypeError: round(): Argument #1 ($num) must be of type int|float, string given #3164

Closed
hebinet opened this issue May 18, 2021 · 2 comments
Labels

Comments

@hebinet
Copy link

hebinet commented May 18, 2021

1️⃣ Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before? (Currently 3.1.x)
Yes

2️⃣ What version of the package, Laravel and PHP do you use? Please provide the FULL version number.
Package: 3.1.30
Laravel: 8.41.0
PHP: 8.0.6

3️⃣ Describe your issue. Please be short, but concise.
There is a problem with formula calulations if a division by 0 occures.
This was fixed in phpoffice/phpspreadsheet v1.17.x (see Issue in Package: PHPOffice/PhpSpreadsheet#1789 ) but in the composer json the Version was pinned to 1.16.x

4️⃣ How can the issue be reproduced? Please provide easy-to-reproduce steps (repository, simple code example, failing unit test).
See PHPOffice/PhpSpreadsheet#1789

5️⃣ What should be the expected behaviour?
See PHPOffice/PhpSpreadsheet#1789

No exception gets thrown and the excel can be generated as normal

6️⃣ Have you filled in the entire issue template? If not, your issue will be closed. Thanks for using the package! 🙌
Yes ;)

@hebinet hebinet added the bug label May 18, 2021
@patrickbrouwers
Copy link
Member

I'm still waiting for a 1.17.2 release of PhpSpreadsheet. 1.17.1 has a bug which makes it unusable for Laravel Excel. Not much we can do until then I'm afraid.

@patrickbrouwers
Copy link
Member

PhpSpreadsheet released 1.18 so it should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants