Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong icon shown when launching with wayland #267

Closed
3 of 5 tasks
martindmtrv opened this issue Sep 20, 2022 · 3 comments
Closed
3 of 5 tasks

Wrong icon shown when launching with wayland #267

martindmtrv opened this issue Sep 20, 2022 · 3 comments
Assignees
Labels
info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. type:build Issues or pull requests associated with the app's compiling and packaging process

Comments

@martindmtrv
Copy link

Aknowledgements

  • I have checked that there's no other issue describing the same or
    similar problem that I currently have, regardless if it has been
    closed or open.

  • I can confirm that this is not an issue with the Discord website,
    but it is a problem specific to the WebCord itself. I have tested
    if this bug occurs on Chromium/Chrome or any other Chromium-based
    browser that uses unpatched/upstream Chromium engine.

  • I have tried running the build from the master branch and it does
    not have any fixes implemented according to my issue.

  • My issue describes one of the unstable and/or not fully implemented
    features.

  • I have found a workaround to mitigate or temporarily fix this issue
    in affected releases (please write it in Additional context section
    below).

Operating System / Platform

🐧️ Linux

Operating system architecture

x64 (64-bit Intel/AMD)

Electron version

v20.0.3

Application version

v3.8.3-2df618b

Bug description

Launching the app with --ozone-platform=wayland causes the wrong icon to be displayed. Found a related issue under the Electron repo but it appears to be fixed now.

It seems that for wayland they map a property called app_id to the WMClass so perhaps this is not set on the WebCord side?

Additional context

image
Screenshot showing the Electron Icon

image
Looking glass showing the WMClass is Electron not WebCord. When launching without wayland enabled, it properly shows WebCord

@martindmtrv martindmtrv added the type:bug Something isn't working label Sep 20, 2022
@martindmtrv
Copy link
Author

Also just now I tried to switch to the latest electron v20.1.4-1 to see if the issue resolves itself there but the icon still is not displaying correctly and the wmclass is still Electron

@SpacingBat3 SpacingBat3 added info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. type:build Issues or pull requests associated with the app's compiling and packaging process and removed type:bug Something isn't working labels Sep 20, 2022
@SpacingBat3
Copy link
Owner

If the issue you're experiencing is not the case with the clients like Element, I think it might be fixed in webcord-git@1b1627a. Since then, WebCord should have defined a WM_CLASS in its .desktop file, at least in case of webcord-git package. I'm not sure how it is with the GitHub packages, but it would be then likely an issue with the maker if something like that would occur there as well.

@italoghost
Copy link

It seems to still be a problem with Electron itself. Tried here with WebCord and FreeTube and both are showing the Electron icon instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:Wayland Issues specific to Wayland, likely caused by lack of support by Electron / Chromium. type:build Issues or pull requests associated with the app's compiling and packaging process
Projects
None yet
Development

No branches or pull requests

3 participants