Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsc build error #234

Closed
marie-haskova opened this issue Aug 25, 2022 · 2 comments
Closed

tsc build error #234

marie-haskova opened this issue Aug 25, 2022 · 2 comments
Assignees
Labels
type:build Issues or pull requests associated with the app's compiling and packaging process

Comments

@marie-haskova
Copy link

marie-haskova commented Aug 25, 2022

Acknowledgements

  • [✅] There's no other issue describing the same problem, regardless of its current state (i.e. including both closed and open issues).*
  • [✅] There's no fix for my issue released to master branch.*
  • [❌] This issue has known workaround (write it below).

* Required

Environment

  • Platform: Arch Linux
  • AUR Helper: paru, tried yay as well
  • Architecture: amd64
  • Electron version: v16.17.0
  • Application version: 3.7.1
  • TypeScript compiler version: 4.7.7
  • Node.js package manager: npm
    • Node.js package manger version: 8.15.0

Describe the problem

tsc fails at dompurify import

To Reproduce

Steps to reproduce the behavior:

  1. clone AUR repo
  2. compile typescript

Expected behavior

succesful compilation

Screenshots

If applicable, add screenshots to help explain your problem.
image
^ above screenshot uses yay

Workarounds

idk adding @types/dompurify?

@marie-haskova marie-haskova added the type:build Issues or pull requests associated with the app's compiling and packaging process label Aug 25, 2022
@SpacingBat3
Copy link
Owner

SpacingBat3 commented Aug 25, 2022

TL;DR: Curse you, DOMPurify!!! 😆


This happens because DOMPurify has started playing with the types at the production, assuming no breakages will occur...
They've announced their own types, which has been now reverted, so the commit should in the WebCord as well.

See: cure53/DOMPurify#713

@marie-haskova
Copy link
Author

I see, thank you for explaining 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:build Issues or pull requests associated with the app's compiling and packaging process
Projects
None yet
Development

No branches or pull requests

2 participants