New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics analyzer for Razor: Lines of code are outside the range of the file #9288

Closed

martin-strecker-sonarsource opened this issue May 16, 2024 · 1 comment · Fixed by #9299

Assignees

Labels

Area: C# Type: Bug

Projects

Milestone

Contributor

martin-strecker-sonarsource commented May 16, 2024

Community report:
https://community.sonarsource.com/t/java-lang-illegalargumentexception-line-575-is-out-of-range-for-file-xxx-file-has-386-lines/108740/15

The razor source generator of .Net SDK 9.0.100-preview.3.24204.13 produces a file with missing #line default and #line hidden directives for using directives:

                #line (1,2)-(2,1) "File.razor"
                using System.Net.Http

                #nullable disable
                    ;
                #nullable restore

Instead, the generated code should look like so:

                #line (1,2)-(2,1) "File.razor"
                using System.Net.Http

                #line default
                #line hidden
                #nullable disable
                    ;
                #nullable restore

As a result, we count the ; as code line but the mapping is beyond the length of the file if the using is the only content of the file like in _Imports.razor

The text was updated successfully, but these errors were encountered:

martin-strecker-sonarsource added Type: Bug Area: C# labels

This was referenced May 16, 2024

Reproducer for Metrics analyzer for Razor: Lines of code are outside the range of the file #9289

Closed

Razor files: Generated code misses #line hidden for using directives dotnet/razor#10375

Open

Contributor Author

martin-strecker-sonarsource commented May 16, 2024

How to fix:
We need to make sure, the range added here is within the document:

sonar-dotnet/analyzers/src/SonarAnalyzer.Common/Metrics/MetricsBase.cs

Line 53 in ef727d3

return Enumerable.Range(start, end - start + 1);

costin-zaharia-sonarsource added a commit that referenced this issue


          Create reproducer for #9288

costin-zaharia-sonarsource mentioned this issue

Create reproducer for #9288 #9297

Merged

costin-zaharia-sonarsource added a commit that referenced this issue


          Create reproducer for #9288

b834b64

costin-zaharia-sonarsource added a commit that referenced this issue


          Create reproducer for #9288

4d442a8

gregory-paidis-sonarsource pushed a commit that referenced this issue


          Create reproducer for #9288 (#9297)

0371dfa

This was referenced May 17, 2024

Metrics analyzer for Razor: Lines of code are outside the range of the file #9299

Merged

Razor mappings: Ensure we check if the mapped span is valid #9305

Merged

github-actions bot assigned martin-strecker-sonarsource

github-actions bot added this to Review in progress in Best Kanban

github-actions bot assigned gregory-paidis-sonarsource and unassigned martin-strecker-sonarsource and gregory-paidis-sonarsource

gregory-paidis-sonarsource closed this as completed in #9299

Best Kanban automation moved this from Review in progress to Validate Peach

github-actions bot assigned costin-zaharia-sonarsource and unassigned gregory-paidis-sonarsource

costin-zaharia-sonarsource added a commit that referenced this issue


          Create reproducer for #9288 (#9297)

25f10b1

costin-zaharia-sonarsource added a commit that referenced this issue


          Create reproducer for #9288 (#9297)

1f540fd

costin-zaharia-sonarsource added a commit that referenced this issue


          Create reproducer for #9288 (#9297)

2e96863

costin-zaharia-sonarsource moved this from Validate Peach to Done in Best Kanban

mary-georgiou-sonarsource added this to the 9.25.1 milestone

costin-zaharia-sonarsource mentioned this issue

Build fails with "java.lang.IllegalArgumentException: Line xx is out of range for file yy File has zz lines." for Blazor apps #9350

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment