diff --git a/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/css/rules/UnitNoUnknown.java b/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/css/rules/UnitNoUnknown.java index 7a9e5fd477..153a1d0687 100644 --- a/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/css/rules/UnitNoUnknown.java +++ b/sonar-javascript-plugin/src/main/java/org/sonar/plugins/javascript/css/rules/UnitNoUnknown.java @@ -19,8 +19,6 @@ */ package org.sonar.plugins.javascript.css.rules; -import java.util.Arrays; -import java.util.List; import org.sonar.check.Rule; @Rule(key = "S4653") @@ -30,14 +28,4 @@ public class UnitNoUnknown implements CssRule { public String stylelintKey() { return "unit-no-unknown"; } - - @Override - public List stylelintOptions() { - return Arrays.asList(true, new StylelintIgnoreOption()); - } - - private static class StylelintIgnoreOption { - // Used by GSON serialization - private final String[] ignoreUnits = {"x"}; - } } diff --git a/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/css/rules/CssRuleTest.java b/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/css/rules/CssRuleTest.java index 78f74b3aa3..fceb9f5187 100644 --- a/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/css/rules/CssRuleTest.java +++ b/sonar-javascript-plugin/src/test/java/org/sonar/plugins/javascript/css/rules/CssRuleTest.java @@ -48,8 +48,7 @@ void rules_default_is_empty() throws NoSuchMethodException, IllegalAccessExcepti PropertyNoUnknown.class, SelectorPseudoClassNoUnknown.class, SelectorPseudoElementNoUnknown.class, - SelectorTypeNoUnknown.class, - UnitNoUnknown.class); + SelectorTypeNoUnknown.class); for (Class ruleClass : CssRules.getRuleClasses()) { CssRule rule = (CssRule)ruleClass.getConstructor().newInstance(); @@ -106,12 +105,6 @@ void selector_pseudo_element_no_unknown_custom() { assertThat(optionsAsJson).isEqualTo("[true,{\"ignorePseudoElements\":[\"ng-deep\",\"/^custom-/\"]}]"); } - @Test - void units_no_unknown_options() { - String optionsAsJson = new Gson().toJson(new UnitNoUnknown().stylelintOptions()); - assertThat(optionsAsJson).isEqualTo("[true,{\"ignoreUnits\":[\"x\"]}]"); - } - @Test void at_rule_unknown_default() { String optionsAsJson = new Gson().toJson(new AtRuleNoUnknown().stylelintOptions());