Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve S104: report on file level #2047

Closed
vilchik-elena opened this issue Jul 30, 2020 · 0 comments · Fixed by #2048
Closed

Improve S104: report on file level #2047

vilchik-elena opened this issue Jul 30, 2020 · 0 comments · Fixed by #2048
Assignees
Milestone

Comments

@vilchik-elena
Copy link
Contributor

vilchik-elena commented Jul 30, 2020

When migrating to eslint-based frontend we started relying on eslint core rule max-lines (#1363). max-lines we reporting on first line of file so did we. Now eslint changed reporting (eslint/eslint#13318) to report on all extra lines. Such reporting is again different and does not look good on Sonar products (especially in SonarLint).

We want to change it back to report on file level to be consistent with other sonar analyzers. We can wrap existing eslint rule to change reported location or create our own rule implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant