From 6cdff3eab66cc90e445138857e326cfbb6065f91 Mon Sep 17 00:00:00 2001
From: yassin-kammoun-sonarsource <yassin.kammoun@sonarsource.com>
Date: Wed, 6 Apr 2022 13:02:01 +0200
Subject: [PATCH] Update CSS plugin expectations

- New issues of S4650 are due to a reimplementation of the rule (see https://github.com/stylelint/stylelint/pull/5636)
- Old issues of S5362 are due to our custom reimplementation of the dropped rule
- Old issue of S4654 seemed to be a false positive, but it's unclear why the issue disappeared
---
 .../projects/css-issues-project/src/file1.css       |  2 +-
 .../sonar/javascript/it/plugin/CssIssuesTest.java   | 13 ++++++-------
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/its/plugin/projects/css-issues-project/src/file1.css b/its/plugin/projects/css-issues-project/src/file1.css
index 9356c8fbb2c..53adb72d5b4 100644
--- a/its/plugin/projects/css-issues-project/src/file1.css
+++ b/its/plugin/projects/css-issues-project/src/file1.css
@@ -34,7 +34,7 @@ a:unknown {                                                   /* S4659 | selecto
   width: calc(100% 80px);                                     /* S5362 | function-calc-no-invalid */
 }
 
-//color: pink;                                               /* S4668 | no-invalid-double-slash-comments */ /* S4654 | property-no-unknown */
+//color: pink;                                               /* S4668 | no-invalid-double-slash-comments */
 
 .class1 {
   width: 100px;
diff --git a/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java b/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java
index 7cc6476fea3..8bb83d92b00 100644
--- a/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java
+++ b/its/plugin/tests/src/test/java/com/sonar/javascript/it/plugin/CssIssuesTest.java
@@ -98,9 +98,10 @@ void issue_list() {
       tuple("css:S4654", "css-issues-project:src/file1.css"),
       tuple("css:S4657", "css-issues-project:src/file1.css"),
       tuple("css:S4650", "css-issues-project:src/file1.css"),
+      tuple("css:S4650", "css-issues-project:src/file1.css"),
+      tuple("css:S4650", "css-issues-project:src/file1.css"),
       tuple("css:S4653", "css-issues-project:src/file1.css"),
       tuple("css:S4668", "css-issues-project:src/file1.css"),
-      tuple("css:S4654", "css-issues-project:src/file1.css"),
       tuple("css:S4651", "css-issues-project:src/file1.css"),
       tuple("css:S4666", "css-issues-project:src/file1.css"),
       tuple("css:S4670", "css-issues-project:src/file1.css"),
@@ -122,6 +123,8 @@ void issue_list() {
       tuple("css:S4654", "css-issues-project:src/file2.less"),
       tuple("css:S4657", "css-issues-project:src/file2.less"),
       tuple("css:S4650", "css-issues-project:src/file2.less"),
+      tuple("css:S4650", "css-issues-project:src/file2.less"),
+      tuple("css:S4650", "css-issues-project:src/file2.less"),
       tuple("css:S4653", "css-issues-project:src/file2.less"),
       tuple("css:S4651", "css-issues-project:src/file2.less"),
       tuple("css:S4666", "css-issues-project:src/file2.less"),
@@ -144,6 +147,8 @@ void issue_list() {
       tuple("css:S4654", "css-issues-project:src/file3.scss"),
       tuple("css:S4657", "css-issues-project:src/file3.scss"),
       tuple("css:S4650", "css-issues-project:src/file3.scss"),
+      tuple("css:S4650", "css-issues-project:src/file3.scss"),
+      tuple("css:S4650", "css-issues-project:src/file3.scss"),
       tuple("css:S4653", "css-issues-project:src/file3.scss"),
       tuple("css:S4651", "css-issues-project:src/file3.scss"),
       tuple("css:S4666", "css-issues-project:src/file3.scss"),
@@ -155,13 +160,7 @@ void issue_list() {
       tuple("css:S1116", "css-issues-project:src/file5.htm"),
       tuple("css:S1116", "css-issues-project:src/file6.vue"),
       tuple("css:S5362", "css-issues-project:src/file1.css"),
-      tuple("css:S5362", "css-issues-project:src/file1.css"),
-      tuple("css:S5362", "css-issues-project:src/file1.css"),
-      tuple("css:S5362", "css-issues-project:src/file2.less"),
-      tuple("css:S5362", "css-issues-project:src/file2.less"),
       tuple("css:S5362", "css-issues-project:src/file2.less"),
-      tuple("css:S5362", "css-issues-project:src/file3.scss"),
-      tuple("css:S5362", "css-issues-project:src/file3.scss"),
       tuple("css:S5362", "css-issues-project:src/file3.scss")
     );
   }