Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor configuration management package #10

Open
2 tasks
GuiBL4 opened this issue May 5, 2023 · 0 comments · May be fixed by #16
Open
2 tasks

Refactor configuration management package #10

GuiBL4 opened this issue May 5, 2023 · 0 comments · May be fixed by #16

Comments

@GuiBL4
Copy link
Contributor

GuiBL4 commented May 5, 2023

Aim

For now, Sleppa configuration crate is not generic.
It loads some value that are defined in structures inside the crate.

In order to be more generic, if a plugin needs a configuration file and/or data, this plugin is in charged to provide a way to load these information.
To implement that, a HashMap and new structure could be used to be more dynamic.

Assumptions

  • Three new structure are added : Context, Configuration and Value
  • Context is a HashMap<String, Value>
  • Configuration is a HashMap<String, Value>
  • Value represents all possible type in the Context : String, Commit, User, Tag and release action.
  • Each plugin implements its own configuration if needed

Acceptance criteria

  • Implements the three new structures
  • Provides methods to interact with these structure

Risks

  • No specific risk

Dependencies

  • No dependencies

References

  • figment: a very generic configuration constructor.
@binadamu-isiyoonekana binadamu-isiyoonekana changed the title Make sleppa_configuration more generics Refactor configuration management package May 10, 2023
@GuiBL4 GuiBL4 linked a pull request May 19, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: status: in progress
Development

Successfully merging a pull request may close this issue.

1 participant