Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TN caches attestation config #766

Open
oleggrib opened this issue Jul 24, 2023 · 1 comment
Open

TN caches attestation config #766

oleggrib opened this issue Jul 24, 2023 · 1 comment
Assignees

Comments

@oleggrib
Copy link
Collaborator

oleggrib commented Jul 24, 2023

TN 2.6.0 caches attestation config and doesn't update it when config changes

steps to reproduce:

  1. start TN with issuer1 : https://devcon-vi.attest.tickets/devcon6.js

  2. update TN issuer to issuer2 : https://stage-perks.smarttokenlabs.com/shanghai_token_demo.js

page still display issuer1

problem solves when I remove LocalStorage variable "tn-tokenStore"

@nicktaras , it happened because of same collectionID, but does it worth to cache data, what already downloaded? Maybe better disable option to cache config?

@nicktaras
Copy link
Collaborator

Thanks @oleggrib - this needs to be looked into. This was added to optimise the UX for re-direct, but has some downsides as you have shared. cc: @micwallace

I'll look at the scenarios we have (good and bad) and share ideas to you and Miccy of what we can do. Where ideally it would be good to keep this or a version of cache here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants