Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show refs for repos with tags (or other "unexpected" refs) #222

Open
mattwynne opened this issue Sep 20, 2020 · 6 comments
Open

Show refs for repos with tags (or other "unexpected" refs) #222

mattwynne opened this issue Sep 20, 2020 · 6 comments
Labels
feature New behaviour added, visible to the user good first issue Good for newcomers pinned

Comments

@mattwynne
Copy link
Contributor

If the code in handleGetRefs throws any kind of error, we just return an empty Refs() object.

The error swallowing was presumably for dealing with calls to show-refin empty repos, but it's also swallowing errors parsing refs.

Need to change this so the try/catch block is only around the call to show-ref and not the parsing bit, so that parsing errors are still thrown.

@mattwynne mattwynne added the good first issue Good for newcomers label Sep 20, 2020
@stale
Copy link

stale bot commented Oct 21, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏.

@stale stale bot added the wontfix label Oct 21, 2020
@mattwynne
Copy link
Contributor Author

Not stale, this is important!

@stale stale bot removed the wontfix label Oct 21, 2020
@mattwynne mattwynne changed the title Can't fetch a repo with tags (or other "unexpected" refs) Fetch repos with tags (or other "unexpected" refs) Nov 11, 2020
@mattwynne mattwynne added the feature New behaviour added, visible to the user label Nov 11, 2020
@stale
Copy link

stale bot commented Dec 11, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏.

@stale stale bot added the wontfix Things we've decided not to do label Dec 11, 2020
@mattwynne
Copy link
Contributor Author

We've got to fix this. It won't take long and it will exclude lots of user's repos.

@stale stale bot removed the wontfix Things we've decided not to do label Dec 11, 2020
@stale
Copy link

stale bot commented Jan 10, 2021

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions 🙏.

@stale stale bot added the wontfix Things we've decided not to do label Jan 10, 2021
@mattwynne mattwynne added pinned feature New behaviour added, visible to the user and removed wontfix Things we've decided not to do feature New behaviour added, visible to the user labels Jan 10, 2021
@mattwynne
Copy link
Contributor Author

I've cleaned up this code and it seems to be working now. Closing.

@mattwynne mattwynne added the wontfix Things we've decided not to do label Mar 12, 2021
@mattwynne mattwynne reopened this Mar 13, 2021
@stale stale bot removed the wontfix Things we've decided not to do label Mar 13, 2021
@mattwynne mattwynne changed the title Fetch repos with tags (or other "unexpected" refs) Show refs for repos with tags (or other "unexpected" refs) Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New behaviour added, visible to the user good first issue Good for newcomers pinned
Projects
None yet
Development

No branches or pull requests

1 participant