Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse click areas (Class List and Content Sections) #8

Open
DanRathbun opened this issue Jan 13, 2017 · 3 comments
Open

Collapse click areas (Class List and Content Sections) #8

DanRathbun opened this issue Jan 13, 2017 · 3 comments

Comments

@DanRathbun
Copy link
Contributor

Collapse Buttons

(1) Their location is annoying. Navigating the docs I'm constantly moving the mouse pointer from the left nav column all the way to the right side.
I much prefer a collapse arrow on the left, with a large click area (if it's a section title then the whole darn line should be clickable.)

(2) They all collapse when one is clicked. Don't like this.
I can see that when I collapse the "Overview" section on one class page, that it remembers this sitewide, until I uncollapse this section on any page. Same for "Constants" and the certain summaries (I'd want the class method and instance method summaries to have a separate toggle.)

(3) Class List collapsers are too small and finicky.
We should be able to click the entire line with the module or classname, and if it is the current content page, then it's subordinate nav list should collapse or uncollapse. Otherwise it's collapse state should remain unchanged when it is not the current content page.

@DanRathbun
Copy link
Contributor Author

DanRathbun commented Jan 17, 2017

Once again, @MSP-Greg has already solved most of these points (above.)

As I mentioned in the other issue #10 (comment),
Greg tried (JUL 2016) to get Loren to accept a revamped styling of the List pane, but Loren wanted all the changes broken up into separate pull requests. See:
lsegal/yard#1000

(1) Greg's solution allows the entire section header to be clicked to fire the toggling.

(2) Greg has already solved the separate collapse/expand for the "Overview" section, as well as making the "Constants" section collapse along with all the methods summaries. (So, the main issue of separately collapsible summary sections, still open.)

(3) Part of Greg's PR had a fix to expand the list member's expand/collapse click areas, from left of the name all the way to the left margin.

In addition, I would like to see either a change in cursor over these expansion "hotspots", or some kind of onHover highlight effect that makes the + and - icons glow.

@MSP-Greg
Copy link

@DanRathbun

In addition, I would like to see either a change in cursor over these expansion "hotspots", or some kind of onHover highlight effect that makes the + and - icons glow.

Good idea. I'll add that.

Part of Greg's PR had a fix to expand the list member's expand/collapse click areas, from left of the name all the way to the left margin.

Mostly did that for tablets, as the YARD target is just too small. The global expand/collapse buttons in the LIST/TOC headers are what I really think YARD should have.

So, the main issue of separately collapsible summary sections, still open.

Not sure I like that. I get confused over what's collapsed (or missing) when I'm tired. A new user...

Re YARD, keep in mind that a lot of html tests are kind of brittle, so re template PR's to YARD, they may be break...

@DanRathbun
Copy link
Contributor Author

@MSP-Greg

Not sure I like that. I get confused over what's collapsed (or missing) when I'm tired. A new user...

Oh, that brings up an issue, I do not like about the default YARD css. I myself feel that collapse / expand is not the same as hide / show. The user should not wonder if info is hidden. I would myself style each collapsible section within a group border. (Similar to a labeled control group in dialog boxes.)

I might like some different right margin when not collapsed. (This border could accept clicks to collapse it, so you do not need to scroll to the top of a section to collapse it.) Just thinking out loud.

Also thinking like perhaps when the box is collapsed, the two side borders get a different style like dashed or dotted lines. Just thinking out loud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants