Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in LogCapture #141

Merged
merged 2 commits into from Sep 30, 2020
Merged

Conversation

zolyfarkas-fb
Copy link
Contributor

No description provided.

@cjw296
Copy link
Member

cjw296 commented Sep 29, 2020

Looks like CircleCI is having some issues. Would you mind rebasing this to lose the merge commit and also lose the [fix] prefix for the commit? (that's not a pattern I use, as you'll see from all the other commits in this repo) - hopefully that will trigger the PR CI to fire again...

@zolyfarkas-fb zolyfarkas-fb changed the title [fix] typo in LogCapture fix typo in LogCapture Sep 29, 2020
@zolyfarkas-fb
Copy link
Contributor Author

@cjw296 changed the commit message. CI is doing this since yesterday, I wasn't able to see the results yet...

@cjw296
Copy link
Member

cjw296 commented Sep 30, 2020

#142 is working, can you try another force push to this branch?
Failing that, perhaps close this PR and open another?

@zolyfarkas-fb
Copy link
Contributor Author

I had to give circle-ci full access to all my public repos, which is a bit excessive to say at least... will revoke the access after I am done with this work. The other ci tools I used don't require this...

@cjw296
Copy link
Member

cjw296 commented Sep 30, 2020

I don't think that was required. CircleCIs status page indicated they were having github webhook issues earlier.

@cjw296 cjw296 merged commit 7048e22 into simplistix:master Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants