Always compare object mappings when ignore_eq is enabled. #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object comparer indirectly relies on the
__eq__
method of attributes in the checkx_attrs != y_attrs
even when ignore_eq is set.This PR changes it to always compare the mappings when ignore_eq is enabled. I have also created a test case using the OrmObj object.
The test_compare.py passes on its own; however when I installed Django to run the other tests; I ran into this error using
pytest testfixtures/tests/test_django/test_compare.py
:I am not sure how to run the tests properly.