Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct confusing name and fix typos #135

Merged
merged 2 commits into from May 6, 2020
Merged

Conversation

dspinellis
Copy link
Contributor

The documentation is about the testfxtures module; remove confusing references to the class-like TestFixtures name.
Also fix the completely wrong references to TestFixtures.

The documentation is about the `testfxtures` module; remove confusing references to the class-like `TestFixtures` name.
Also fix the completely wrong references to `TestFixtures`.
@cjw296
Copy link
Member

cjw296 commented May 6, 2020

The documentation is about the TestFixtures distribution, which I'm not sure I like capitalisation-wise anymore, but that package contains a testfixtures package.
I don't think there is a testfixtures module anymore.

I'm afraid there is nothing "completely wrong" in the text you've changed.

What problems has this text caused you that you felt the need to see if changed?

@dspinellis
Copy link
Contributor Author

dspinellis commented May 6, 2020

You are correct regarding the module term. I changed the module references into package references.

The references to TestFixtures made me look for a class with that name and try to use one.

The "completely wrong" parts I fixed were references to TextFixtures (Text, not Test).

@cjw296
Copy link
Member

cjw296 commented May 6, 2020

Ah okay, the typo fixes in their own commit would have been easier to review :-)

@cjw296 cjw296 merged commit ffa52d9 into simplistix:master May 6, 2020
@dspinellis
Copy link
Contributor Author

Thank you! BTW testfixtures is awesomely cool! It allowed me to test and debug a complex time-dependent interaction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants