Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting Multiple Input Sources #105

Open
adodge-bcg opened this issue May 29, 2020 · 1 comment
Open

Supporting Multiple Input Sources #105

adodge-bcg opened this issue May 29, 2020 · 1 comment
Assignees
Projects

Comments

@adodge-bcg
Copy link
Contributor

adodge-bcg commented May 29, 2020

Issue:
With the current implementation, to add an additional source, a conversion from the sources payload to Teams and RocketChat is required. Each additional source will require new conversions for each Chat app supported. Ie. Splunk to Teams, Splunk to Rocket, Kabana to Teams, Kabana to Rocket. Not bad now, but each time you want to add a new source or destination there needs to be a conversion added for all the existing destinations/sources.

Proposal:
A generic alert object that all incoming objects are converted into, and that can be mapped to outgoing chat platforms. Therefore, each added source only needs to implement a conversion to the generic object, and each added destination only has to map the generic.

Faults:
This could prevent or interfere with the utilization of platform-specific features. Ie. Harder to support specific buttons for links in Teams while not requiring fields that other sources may not have or use.

@adodge-bcg adodge-bcg created this issue from a note in MVP (Todo) May 29, 2020
@adodge-bcg adodge-bcg self-assigned this May 29, 2020
@adodge-bcg adodge-bcg moved this from Todo to In Progress in MVP May 29, 2020
@alexjoybc
Copy link
Contributor

I would wait a bit on implementing this until we have a need for it. The reason being that unlike splunk we don't know exactly the requirement here and we might implement something that is dead code and not in use. what do you think @adodge-bcg ?

@adodge-bcg adodge-bcg moved this from In Progress to In review in MVP Jun 3, 2020
@adodge-bcg adodge-bcg moved this from In review to Done in MVP Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MVP
  
Done
Development

No branches or pull requests

3 participants