Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recusrive call is not supported in "time_to_combustion_value() #842

Open
InvalidTheory opened this issue Feb 21, 2021 · 2 comments
Open

Comments

@InvalidTheory
Copy link

I am receiving recusrive error for "time_to_combustion_value()" and "time_to_combustion()

AddFunction time_to_combustion_value

@tehmufifnman
Copy link
Contributor

Also running into this issue =(

@Erstyx
Copy link

Erstyx commented Jul 1, 2021

So it looks like time_to_combustion used to have the definition

talentpoints(firestarter_talent) * TargetTimeToHealthPercent(90) + spellcooldown(combustion) * { 1 - kindling_reduction() * talentpoints(kindling_talent) } * { not { spellcooldown(combustion) <= 0 } * buffexpires(combustion) }

Then an update tried to move that definition to time_to_combustion_value() and change time_to_combustion() to wrap it in a ceiling check, but instead copied the ceiling to both places. So it might work to replace lines 1207-1208 with the previous definition of time_to_combustion() [above].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants