Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue & druid finishers incorrectly state max_combopoints=4 #836

Open
johnnylam88 opened this issue Feb 2, 2021 · 0 comments
Open

Rogue & druid finishers incorrectly state max_combopoints=4 #836

johnnylam88 opened this issue Feb 2, 2021 · 0 comments

Comments

@johnnylam88
Copy link
Contributor

Rogue & druid finishers incorrectly state max_combopoints=4 when it
should be max_combopoints=5, although rogue finishers can also use up
to 6 combopoints if Deeper Strategem is talented.

There are two issues:

  1. The script that imports the spell database may need to be adjusted
    to output the correct value for max_combopoints.
  2. This may alternatively be addressed by fix(power): fix semantics of {max,set,refund}_XXX in SpellInfo() #835
    by removing all of the max_combopoints properties and instead just
    adding set_combopoints=0. Using this style will avoid needing to
    know what exactly is the maximum number of combopoints that can be
    spent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant