Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable documentation generation by default #920

Merged
merged 1 commit into from May 3, 2022
Merged

Enable documentation generation by default #920

merged 1 commit into from May 3, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented May 3, 2022

Motivation

  • This feature makes the whole VS Code experience so much better
  • It's been battle tested for quite a long now and works well
  • It's slow only for a very limited number of gems, let's have people disable it if needed instead

Implementation

!false

Tests

See automated tests.

@Morriar
Enable documentation generation by default
69f63a0 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the enhancement New feature or request label May 3, 2022
@Morriar Morriar requested a review from a team May 3, 2022 16:18
@Morriar Morriar self-assigned this May 3, 2022
@Morriar Morriar mentioned this pull request May 3, 2022
Merged
paracycle
paracycle approved these changes May 3, 2022
View reviewed changes
Copy link
Member

@paracycle paracycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Morriar Morriar merged commit b57f315 into main May 3, 2022
@Morriar Morriar deleted the at-gen-doc branch May 3, 2022 18:08
@Morriar Morriar mentioned this pull request May 13, 2022
Merged
@shopify-shipit shopify-shipit bot temporarily deployed to production May 13, 2022 23:08 Inactive
@shopify-shipit shopify-shipit bot temporarily deployed to 0-8-stable May 30, 2022 13:45 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paracycle paracycle paracycle approved these changes

@vinistock vinistock vinistock approved these changes

Assignees

@Morriar Morriar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Morriar @paracycle @vinistock