Improve README #917
Merged
Improve README #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
May 3, 2022
| @@ -1,60 +1,48 @@ | |||
| > :warning: **Note**: This software is currently under active development. The API and interface should be considered unstable until a v1.0.0 release. | |||
|
|
|||
| # Tapioca | |||
| <p align="center"> | |||
| <img alt="Tapioca logo" width="200" src="misc/tapioca-logo.svg" /> | |||
Morriar
force-pushed
the
at-doc
branch
2 times, most recently
from
6c8e8a6
to
9f956d4
Compare
paracycle
reviewed
May 3, 2022
README.md
Outdated
| * Easy installation and configuration | ||
| * Generation of RBI files for the gems used in your application | ||
| * Automatic generation from your application's Gemfile | ||
| * Signatures importation from the gems source code |
There was a problem hiding this comment.
I believe importation is not the correct word here:
Suggested change
| * Signatures importation from the gems source code | |
| * Importing of signatures from the gem source code |
There was a problem hiding this comment.
I applied the first change but kept gems plural as its used plural in the other bullet points if it's okay with you?
paracycle
approved these changes
May 3, 2022
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes https://github.com/Shopify/sorbet-issues/issues/248.