Add descriptive message for unexpected DSL exceptions #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
reviewed
Apr 29, 2022
Currently, when a DSL compiler raises an error while running a `decorate` operation, it is not very obvious which compiler failed and during the processing of which constant. The failing DSL compiler is kind of obvious if one looks at the backtrace, but the constant that it is failing on is very hard to understand if one is not running DSL generation in verbose mode. This PR handles unexpected exceptions, shows a friendly error message for them and re-raises the exception to keep the current behaviour.
paracycle
force-pushed
the
uk-better-exceptions
branch
from
65cb9ee
to
58965e4
Compare
vinistock
approved these changes
Apr 29, 2022
|
Best PR ever! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, when a DSL compiler raises an error while running a
decorateoperation, it is not very obvious which compiler failed and during the processing of which constant. The failing DSL compiler is kind of obvious if one looks at the backtrace, but the constant that it is failing on is very hard to understand if one is not running DSL generation in verbose mode.Implementation
This PR handles unexpected exceptions, shows a friendly error message for them and re-raises the exception to keep the current behaviour.
Tests
Added a test with a failing DSL compiler.