Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ignore the vendor/ directory form the sorbet/config #848

Merged
merged 1 commit into from Mar 9, 2022

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Mar 9, 2022

Motivation

This directory can be safely ignored and this will avoid a lot of Sorbet type errors out of the box after a tapioca init.

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
@Morriar Morriar force-pushed the at-uk-default-ignore-vendor branch from a9bc142 to f4b4a9c Compare March 9, 2022 21:21
@Morriar Morriar requested a review from a team March 9, 2022 21:21
@Morriar Morriar added the enhancement New feature or request label Mar 9, 2022
Copy link
Contributor

@KaanOzkan KaanOzkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Morriar Morriar merged commit eb7c76d into main Mar 9, 2022
@Morriar Morriar deleted the at-uk-default-ignore-vendor branch March 9, 2022 21:34
@shopify-shipit shopify-shipit bot temporarily deployed to production May 13, 2022 23:08 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants