Handle gracefully if we get unparsable JSON #933
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We seem to sometimes not read enough bytes from the Sorbet output, which ends up causing us to get an error from the JSON parser. While we investigate and fix that root cause, we might as well gracefully handle JSON parsing errors.
Implementation
Rescue JSON parsing errors
Tests
No tests, since I don't know how to recreate this situation.