-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for bundler 2.2.25+ #446
Conversation
Sidenote: Do we need the actions to run on Push and PR or would just having it on Push be OK? |
Hmm those tests are passing locally. 👀ing. |
bundle _${{ bundler_version }}_ exec ... Also, you don't need quotes in the matrix versions. |
Tidied up! Thanks Vini. Those same tests are still failing, will keep digging! EDIT: I think a change in smart properties means the test needs a cheeky update. Curious why it isn't failing locally though... |
74cc416
to
8c215c6
Compare
f51c9ba
to
478652e
Compare
91aea76
to
875ed76
Compare
I'll fix the branch protection and ⛵ . EDIT actually I'll ⛵ first so I don't block other people by setting branch protection that they can't possibly meet. |
875ed76
to
9d2c993
Compare
Add support for bundler 2.2.25+
Motivation
Add support for Bundler 2.2.25 and up.
Fix #413
Implementation
materialize
method for bundler versions 2.2.25 and up.Tests