Improve dsl --verify failure message a bit #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanBrushett
changed the title
rafaelfranca
approved these changes
May 13, 2021
paracycle
approved these changes
May 14, 2021
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
RyanBrushett
force-pushed
the
ryanb-verify-failure-message
branch
from
36d56ad
to
378a8e5
Compare
Morriar
approved these changes
May 14, 2021
Co-authored-by: Alexandre Terrasa <583144+Morriar@users.noreply.github.com>
RyanBrushett
force-pushed
the
ryanb-verify-failure-message
branch
from
e46eafc
to
567a787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There seems to be a bit of confusion around the workflow of a failure in the
dsl --verifycommand.Implementation
Lay out a little clearer what people need to do with slightly more thorough messaging.
Tests
Updated! 馃帀