Resolve security alerts #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutecipher
force-pushed
the
resolve-security-alerts
branch
from
6e0aacf
to
50a3665
Compare
rafaelfranca
approved these changes
May 14, 2021
Ran `bundle update rails` to resolve CVE-2021-22885, CVE-2021-22880, GHSA-vr8q-g5c7-m54m, and GHSA-cfjv-5498-mph5.
Bumped Rails again to v5.2.6 and lock `nokogiri` to last Ruby 2.4 supported v1.10.10. Signed-off-by: Cory Hutchison <cory.hutchison@shopify.com>
mutecipher
force-pushed
the
resolve-security-alerts
branch
from
50a3665
to
fe1f08d
Compare
Co-authored-by: Rafael França <rafael.franca@shopify.com>
vinistock
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ran
bundle update railsto resolve the following security advisories:Implementation
Ran
bundle update railswhich updated related dependencies. Needed to go back and lock Nokogiri at v1.10.10 as it was bumped to v1.11.0 which no longer supports Ruby 2.4.Tests
No changes to tests, but current tests continue to pass.